Skip to content

ci: set fail-fast to false on tests matrix to prevent platform blind spots#5153

Merged
jedel1043 merged 1 commit intoboa-dev:mainfrom
RishavTiwari25:ci/add-fail-fast-false
Mar 19, 2026
Merged

ci: set fail-fast to false on tests matrix to prevent platform blind spots#5153
jedel1043 merged 1 commit intoboa-dev:mainfrom
RishavTiwari25:ci/add-fail-fast-false

Conversation

@RishavTiwari25
Copy link

This Pull Request fixes/closes #5152 .

It changes the following:

  • Appends the explicit fail-fast: false property to the tests matrix strategy block within .github/workflows/rust.yml.
  • Enhances developer diagnostic visibility by guaranteeing that every OS environment (macos, windows, ubuntu, ubuntu-arm) successfully completes its full test suite execution, even if a sibling platform fails first.
  • Prevents GitHub Actions' default behavior from instantly force-cancelling the entire pipeline, eliminating "platform blind spots" where developers are unaware of platform-specific regressions.

@github-actions github-actions bot added the Waiting On Review Waiting on reviews from the maintainers label Mar 19, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 19, 2026
@github-actions github-actions bot added C-Builtins PRs and Issues related to builtins/intrinsics C-Actions Pull requests that update Github Actions code labels Mar 19, 2026
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 50,073 50,073 0
Ignored 2,072 2,072 0
Failed 818 818 0
Panics 0 0 0
Conformance 94.54% 94.54% 0.00%

Tested main commit: 055ee0958ce332f3f99af27536a7c6f9a91def27
Tested PR commit: 2bebcb66baabeea1e98122f1d1b1fecc7fa113d8
Compare commits: 055ee09...2bebcb6

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.51%. Comparing base (6ddc2b4) to head (2bebcb6).
⚠️ Report is 892 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5153       +/-   ##
===========================================
+ Coverage   47.24%   59.51%   +12.27%     
===========================================
  Files         476      580      +104     
  Lines       46892    63181    +16289     
===========================================
+ Hits        22154    37602    +15448     
- Misses      24738    25579      +841     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@jedel1043 jedel1043 added this pull request to the merge queue Mar 19, 2026
@jedel1043 jedel1043 added the A-Meta Issues and PRs related to the repository itself label Mar 19, 2026
Merged via the queue into boa-dev:main with commit dd1efc2 Mar 19, 2026
22 checks passed
@github-actions github-actions bot removed the Waiting On Review Waiting on reviews from the maintainers label Mar 19, 2026
@jedel1043 jedel1043 removed the C-Builtins PRs and Issues related to builtins/intrinsics label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Meta Issues and PRs related to the repository itself C-Actions Pull requests that update Github Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: set fail-fast: false on the tests matrix to prevent platform blind spots

2 participants